Skip to content

fix(GitRemoteBranchSelect): update fetcher key to use deferred URL value - #8905

Merged
gatzjames merged 1 commit into
Kong:developfrom
gatzjames:fix/cache-invalidation-on-remote-branch-list
Jul 24, 2025
Merged

fix(GitRemoteBranchSelect): update fetcher key to use deferred URL value#8905
gatzjames merged 1 commit into
Kong:developfrom
gatzjames:fix/cache-invalidation-on-remote-branch-list

Conversation

@gatzjames

@gatzjames gatzjames commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Overview:

In the new remote-branch-select we use the deferred url to fetch the latest branches which can lead to a race condition and fetch the previous data.

We use the deferred url as a cache key for the fetcher instead to make sure these two are synchronized

@gatzjames gatzjames self-assigned this Jul 24, 2025
@gatzjames
gatzjames requested a review from a team July 24, 2025 11:54
@gatzjames
gatzjames enabled auto-merge (squash) July 24, 2025 11:57

@pavkout pavkout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gatzjames
gatzjames force-pushed the fix/cache-invalidation-on-remote-branch-list branch from b7d9534 to 06e157d Compare July 24, 2025 12:51
@gatzjames
gatzjames merged commit f220e2e into Kong:develop Jul 24, 2025
9 of 11 checks passed
@gatzjames
gatzjames deleted the fix/cache-invalidation-on-remote-branch-list branch July 24, 2025 13:20
RoamingLost pushed a commit to RoamingLost/insomnia that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants