replace lodash with es-toolkit - #8909
Merged
Merged
Conversation
ihexxa
reviewed
Jul 28, 2025
ihexxa
left a comment
ihexxa
left a comment
Contributor
There was a problem hiding this comment.
Good strategy for evolving util functions.
jackkav
marked this pull request as ready for review
July 28, 2025 07:35
ihexxa
approved these changes
Jul 30, 2025
ihexxa
left a comment
ihexxa
left a comment
Contributor
There was a problem hiding this comment.
I saw BingBing's question and i think it's valid point with the scripting feature. Also as this blocks other component upgrading so overall it seems fine to move forward to the aligned direction and minor potential unsupported ones could be tackled as regressions if it really happened.
jackkav
force-pushed
the
replace-lodash-with-es-toolkit
branch
from
July 30, 2025 10:29
07335bd to
f7a2fd7
Compare
jackkav
enabled auto-merge (squash)
July 30, 2025 10:29
jackkav
disabled auto-merge
July 30, 2025 10:30
jackkav
force-pushed
the
replace-lodash-with-es-toolkit
branch
from
July 31, 2025 06:27
f7a2fd7 to
ce09fa4
Compare
jackkav
enabled auto-merge (squash)
July 31, 2025 06:39
RoamingLost
pushed a commit
to RoamingLost/insomnia
that referenced
this pull request
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lodash doesn't play nice with es modules, and holds us back from some architectural goals
this is effectively a polyfill for it so we can continue to support it as an ambient script env module.