Skip to content

Refactor/db get descandents - [INS-1075] - #8948

Merged
CurryYangxx merged 13 commits into
developfrom
refactor/db-get-descandents
Aug 27, 2025
Merged

Refactor/db get descandents - [INS-1075]#8948
CurryYangxx merged 13 commits into
developfrom
refactor/db-get-descandents

Conversation

@CurryYangxx

@CurryYangxx CurryYangxx commented Aug 7, 2025

Copy link
Copy Markdown
Member
  • create new function for get descandents
  • generate descandent map from query type
  • complete the descandents map for all data models
  • replace origin withDescandents one by one

@CurryYangxx
CurryYangxx marked this pull request as draft August 7, 2025 02:47
@CurryYangxx CurryYangxx changed the title Refactor/db get descandents Refactor/db get descandents - [INS-1075] Aug 7, 2025
Dustin4444

This comment was marked as off-topic.

Comment thread packages/insomnia/src/models/index.ts Outdated
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch from c6ce3c1 to 065e224 Compare August 7, 2025 07:17
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch from e1c3946 to 8739c0f Compare August 14, 2025 09:25
@CurryYangxx
CurryYangxx requested a review from ZxBing0066 August 14, 2025 09:27

@ZxBing0066 ZxBing0066 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread packages/insomnia/src/common/database.ts Outdated
Comment thread packages/insomnia/src/models/index.ts Outdated
Comment thread packages/insomnia/src/models/index.ts
Comment thread packages/insomnia/src/ui/components/modals/proto-files-modal.tsx
Comment thread packages/insomnia/src/ui/components/tabs/tab-list.tsx
Comment thread packages/insomnia/src/ui/components/templating/tag-editor.tsx
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch 2 times, most recently from 4c35f62 to f52617d Compare August 19, 2025 03:05
ZxBing0066
ZxBing0066 previously approved these changes Aug 19, 2025

@ZxBing0066 ZxBing0066 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. But I'm not sure if the descendant map is complete. May need other folks who have enough knowledge help to check.

Comment thread packages/insomnia/src/common/insomnia-v5.ts Outdated
Comment thread packages/insomnia/src/common/__tests__/database.test.ts Outdated
Comment thread packages/insomnia/src/common/database.ts Outdated
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch 2 times, most recently from da04b3f to 5c6e303 Compare August 27, 2025 03:23
@CurryYangxx
CurryYangxx requested a review from ZxBing0066 August 27, 2025 03:23
@CurryYangxx
CurryYangxx marked this pull request as ready for review August 27, 2025 03:23
ZxBing0066
ZxBing0066 previously approved these changes Aug 27, 2025
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch from d298bc9 to 21314d7 Compare August 27, 2025 03:52
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch from d915156 to 601ec29 Compare August 27, 2025 08:22
@CurryYangxx
CurryYangxx requested a review from ZxBing0066 August 27, 2025 08:40
@CurryYangxx
CurryYangxx enabled auto-merge (squash) August 27, 2025 08:40
@CurryYangxx
CurryYangxx force-pushed the refactor/db-get-descandents branch from 601ec29 to 0f7f2c0 Compare August 27, 2025 08:53
@CurryYangxx
CurryYangxx merged commit 6828712 into develop Aug 27, 2025
14 checks passed
@CurryYangxx
CurryYangxx deleted the refactor/db-get-descandents branch August 27, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants