Skip to content

fix: enable dataFolders constraint for CLI - INS-1064#8955

Merged
ihexxa merged 21 commits into
developfrom
fix/data-folder-3
Aug 13, 2025
Merged

fix: enable dataFolders constraint for CLI - INS-1064#8955
ihexxa merged 21 commits into
developfrom
fix/data-folder-3

Conversation

@ihexxa

@ihexxa ihexxa commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Add dataFolders arg for explicitly specifying directories that can be accessed
  • Add path validators

@ihexxa ihexxa self-assigned this Aug 8, 2025
@ihexxa
ihexxa force-pushed the fix/data-folder-3 branch from d82b7c6 to 28c9d09 Compare August 11, 2025 03:06
cwangsmv
cwangsmv reviewed Aug 11, 2025
View reviewed changes
Comment thread packages/insomnia/src/common/send-request.ts Outdated
// skip plugins
const renderedRequest = renderedResult.request;

isFsAccessingAllowed(renderedRequest, mutatedContext.settings);

@cwangsmv cwangsmv Aug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also consider requestData.caCert? It will include the path of the customized ca cert file

@cwangsmv cwangsmv Aug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutatedContext.clientCertificates will also contain path on cert attribute

@ihexxa ihexxa Aug 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will add them.

@ihexxa ihexxa changed the title fix: enable dataFolders constraint for CLI fix: enable dataFolders constraint for CLI - INS-1064 Aug 11, 2025
@ihexxa
ihexxa force-pushed the fix/data-folder-3 branch 4 times, most recently from 2158a62 to 8c34a13 Compare August 13, 2025 02:48
cwangsmv
cwangsmv previously approved these changes Aug 13, 2025
View reviewed changes

@cwangsmv cwangsmv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa
ihexxa force-pushed the fix/data-folder-3 branch from 87dce39 to f2c0f5c Compare August 13, 2025 07:44
@ihexxa
ihexxa force-pushed the fix/data-folder-3 branch from f2c0f5c to 3ba36d7 Compare August 13, 2025 08:02
@ihexxa
ihexxa merged commit 2f220d4 into develop Aug 13, 2025
14 checks passed
@ihexxa
ihexxa deleted the fix/data-folder-3 branch August 13, 2025 09:19
@sunderhus

sunderhus commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

@ihexxa I think it would be great to have a quick-add button on the popup message for unauthorized paths.
This way, with a single click, you could add the current file you’re trying to use in a request, instead of asking the user to select the path from the alert message, copy it, and add it manually to the Settings.

@ihexxa

ihexxa commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sunderhus Thanks for the feedback and ill also forward this to the team, ux improvement is in progress and will be shipped in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwangsmv cwangsmv cwangsmv approved these changes

Assignees

@ihexxa ihexxa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ihexxa @sunderhus @cwangsmv