add iconv-lite encode#8956
Merged
Merged
Conversation
cwangsmv
reviewed
Aug 14, 2025
| if (encoding !== 'hex' && encoding !== 'latin1' && encoding !== 'base64') { | ||
| async run(context, algorithm: 'md5' | 'sha1' | 'sha256' | 'sha512', encoding: 'hex' | 'base64', value = '') { | ||
| if (encoding !== 'hex' && encoding !== 'base64') { | ||
| throw new Error(`Invalid encoding ${encoding}. Choices are hex, latin1, base64`); |
Contributor
There was a problem hiding this comment.
Nit: Since we do not provide latin1 encoding, we should remove this in error message
cwangsmv
previously approved these changes
Aug 14, 2025
Contributor
|
Update the md5 tag smoke test to compare with MD5 output value |
jackkav
force-pushed
the
add-encode-brdige-for-iconv-lite
branch
from
dad8098 to
6029c8e
Compare
cwangsmv
approved these changes
Aug 14, 2025
jackkav
force-pushed
the
add-encode-brdige-for-iconv-lite
branch
from
6029c8e to
e27ae91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extend bridge to include encoding in order to continue support for md5 hash output
closes INS-1061