Repository navigation
fix: add lock to project-related operations to avoid race condition issues - #8985
Merged
Merged
Conversation
ZxBing0066
commented
Aug 13, 2025
| return wrappedFn as T; | ||
| }; | ||
|
|
||
| return { wrapWithLock, lock, unlock }; |
Member
Author
There was a problem hiding this comment.
After we unify all the project related APIs into the same entry, lock and unlock could be removed.
Contributor
|
The mutex lock implementation have potential dead lock situation We shall make sure no lock function will call another function that acquires the same lock. |
Member
Author
@cwangsmv yes, but I think that's a bug of the implementation rather than a bug of the lock. Just like we return a new promise but forget to resolve it. |
CurryYangxx
previously approved these changes
Aug 14, 2025
yaoweiprc
previously approved these changes
Aug 14, 2025
ZxBing0066
enabled auto-merge (squash)
August 14, 2025 09:20
cwangsmv
previously approved these changes
Aug 14, 2025
ZxBing0066
disabled auto-merge
August 14, 2025 09:34
ZxBing0066
dismissed stale reviews from cwangsmv, yaoweiprc, and CurryYangxx
via
August 14, 2025 09:39
d636895
CurryYangxx
approved these changes
Aug 14, 2025
ZxBing0066
enabled auto-merge (squash)
August 14, 2025 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INS-1107
Background
Sync projects are not only called by SSE, but also when we switch the organization or via an action.
Changes