fix: sendRequest doesnt return error in some cases - INS-1262

[ihexxa]

Changes

• Return error when there's error in sendRequest
• requestToCurlOptions always returns request body mime type as the body could be empty

Tested cases from: #9031 #8897

[ZxBing0066]

Seems there's some boilerplate code. Could we make the code simpler? like:

const promise = new Promise<Response | undefined>(async (resolve, reject) => {
  try {
    // ...
    resolve(result);
  } catch (e) {
    // ...
    reject(e);
  }
})

if(cb) {
  try {
    const result = await promise;
    cb(undefined, result);
  } catch(e) {
    cb(e);
  }
}

return promise;

[ihexxa]

Seems there's some boilerplate code. Could we make the code simpler? like:

const promise = new Promise<Response | undefined>(async (resolve, reject) => {
  try {
    // ...
    resolve(result);
  } catch (e) {
    // ...
    reject(e);
  }
})

if(cb) {
  try {
    const result = await promise;
    cb(undefined, result);
  } catch(e) {
    cb(e);
  }
}

return promise;

Cool, will refactor it a bit.

[jackkav]

This promise callback is an async function, why not just await the response? why use these promise then chains? Very difficult to understand error cases.

[ihexxa]

@jackkav Firstly I agreed that await the response is more reasonable, there's background of it, we digged into this before, as the existing interface which only supports callback, which doesn't require await while it works in kindof synchronous way, the weird behavior makes the implementation tricky. I will take a look to see if i could make it more straightforward but honestly I'm not sure how much can be improved.