Skip to content

fix: truncate cookie string - #9095

Merged
ZxBing0066 merged 4 commits into
developfrom
fix/cookie-string-truncate
Sep 9, 2025
Merged

ZxBing0066 merged 4 commits into
developfrom
fix/cookie-string-truncate

Conversation

@ZxBing0066

@ZxBing0066 ZxBing0066 commented Sep 4, 2025 •

Copy link
Copy Markdown
Member

INS-1340

fixes #9087

Background

Cookie modal doesn't have a reasonable scrollable style.

Changes

  • Change cookie related modals to be scrollable
  • Add line-clamp-3 to cookie value string
image image

@ZxBing0066
ZxBing0066 requested review from a team and Copilot September 4, 2025 09:02
@ZxBing0066 ZxBing0066 self-assigned this Sep 4, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes UI issues with cookie modal components by improving their scrolling behavior and truncating long cookie value strings for better readability.

  • Updates modal layout classes to support proper scrolling
  • Adds line clamping to truncate cookie value strings to 3 lines
  • Changes container layout from items-center to vertical padding for better responsive behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/insomnia/src/ui/components/modals/cookies-modal.tsx
@ZxBing0066
ZxBing0066 enabled auto-merge (squash) September 9, 2025 02:49
@ZxBing0066
ZxBing0066 disabled auto-merge September 9, 2025 03:04
@ZxBing0066
ZxBing0066 enabled auto-merge (squash) September 9, 2025 03:04
@ZxBing0066
ZxBing0066 merged commit 06ef8b7 into develop Sep 9, 2025
14 checks passed
@ZxBing0066
ZxBing0066 deleted the fix/cookie-string-truncate branch September 9, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cookie managaer overflow and scroll doesnt work

3 participants