fix: workspace create fails on windows - #9101
Merged
Merged
Conversation
jackkav
marked this pull request as ready for review
September 5, 2025 13:34
jackkav
force-pushed
the
fix/backup-test-workspace-create
branch
from
September 5, 2025 13:35
b391be0 to
ce340f3
Compare
jackkav
enabled auto-merge (squash)
September 5, 2025 16:00
gatzjames
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these is a flake on windows that causes resource busy when opening the app and creating a request, this ticket aims to resolve that flake, ideally by resolving the resource busy race condition. If that is not possible or too challenging we can add other actions before the add request.
approach: await the backup to complete during app start, this will delay app start on users with larger databases. Previously it was concurrent but it causes a race condition on windows.