feat(*) allow Pongo itself to run inside a docker container #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
force-pushed
the
containerized
branch
3 times, most recently
from
b4b01ca
to
4a21b9a
Compare
Tieske
commented
Jul 23, 2020
|
Hi @Tieske We would love to use this feature. Can this PR be merged soon? |
|
@hieudbui I need some feedback from users before doing so. Can you confirm it works for you? |
|
@Tieske I can confirm this is working for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Pongo itself to run inside a container.
Note: to test this branch, follow the walk-through that was added to the readme, but make sure when cloning Pongo to checkout this branch.