Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imposed posix path to avoid push issues on Windows #21

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@neo291
Copy link
Contributor

commented Feb 13, 2019

The path plugin uses the platform specific separator when join path, this cause problems on windows, to avoid them I've forced the posix version of the path plugin that seems to make it work properly.

Imposed posix path to avoid push issues on Windows
The path plugin uses the platform specific separator when join path, this cause problems on windows, to avoid them I've forced the posix version of the path plugin that seems to make it work properly.
@Jlawlzz
Copy link
Contributor

left a comment

Tested locally, LGTM 🎉

@Jlawlzz Jlawlzz merged commit 1e0cba4 into Kong:master Feb 13, 2019

@neo291 neo291 deleted the neo291:patch-1 branch Feb 13, 2019

nijikokun added a commit that referenced this pull request May 13, 2019

fix: update dev-master with master branch (#29)
* fix(readme): typos (#12)

* fix(pull): add filetype to pull command (#13)

* fix(pull): add console.log context to pull command (#14)

* Imposed posix path to avoid push issues on Windows (#21)

The path plugin uses the platform specific separator when join path, this cause problems on windows, to avoid them I've forced the posix version of the path plugin that seems to make it work properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.