Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema) add support for ttl #3603

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@bungle
Copy link
Member

commented Jul 10, 2018

Summary

Adds support for entity schemas for ttl = true and ttl = false which enables or disables ttl support for the entitity.

This is first PR in series of PRs that implement the ttl support in new model.

@bungle bungle requested a review from hishamhm Jul 10, 2018

@hishamhm

This comment has been minimized.

Copy link
Member

commented Jul 10, 2018

The PR looks good! A question about the reserved field, since it affects the strategy implementation: would it make sense to make expires_at reserved too in case of ttl = true, to allow for both kinds of implementations?

@hishamhm

This comment has been minimized.

Copy link
Member

commented Jul 10, 2018

Followup: @bungle explained that the ttl name can be used for both relative-time and absolute-time implementations (and it will remain hidden as a strategy-level implementation detail), so no need to reserve another name.

Given that, the PR LGTM!

@bungle bungle merged commit f618804 into next Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
TYPE = "missing type declaration",
FIELDS_ARRAY = "each entry in fields must be a sub-table",
FIELDS_KEY = "each key in fields must be a string",
ENDPOINT_KEY = "value must be a field name",
ENDPOINT_KEY_UNIQUE = "endpoint key must be a unique field",
TTL_RESERVED = "ttl is a reserved field name when ttl is enabled",

This comment has been minimized.

Copy link
@Tieske

Tieske Jul 11, 2018

Member

this message seems a bit vague to me?

This comment has been minimized.

Copy link
@hishamhm

hishamhm Jul 11, 2018

Member

In context it makes sense. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.