Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(db) default behavior was changed for how dao handled missing fields (ngx.null to nil) #3710

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@bungle
Copy link
Member

bungle commented Aug 16, 2018

Summary

Refactor DAO and Admin API so that Admin API uses nulls and DAO doesn't use them by default (makes them Lua-land nils aka missing values).

Fix #3617, #3609

@bungle bungle force-pushed the refactor/db-null-nil branch from 70a5f41 to 61a569a Aug 16, 2018

@bungle bungle requested a review from hishamhm Aug 16, 2018

@bungle bungle force-pushed the refactor/db-null-nil branch 7 times, most recently from 62f00c1 to be68f7b Aug 17, 2018

@thibaultcha

This comment has been minimized.

Copy link
Member

thibaultcha commented Aug 28, 2018

@bungle Would you mind porting fixes from this patch as separate commit to the appropriate branche(s) now?

@bungle

This comment has been minimized.

Copy link
Member Author

bungle commented Aug 29, 2018

@thibaultcha Yes, I will look at it.

@bungle

This comment has been minimized.

Copy link
Member Author

bungle commented Sep 15, 2018

@thibaultcha I will close this now, as there are now separate PRs:

@bungle bungle closed this Sep 15, 2018

@bungle bungle deleted the refactor/db-null-nil branch Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.