Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) bump DNS lib to 2.2.0, introducing ttl-override #3730

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@Tieske
Copy link
Member

commented Aug 28, 2018

This bump fixes a number of minor issues (see
https://github.com/Kong/lua-resty-dns-client#history), and
introduces a new option to override the DNS record ttl.

@Tieske Tieske requested review from thibaultcha and hishamhm Aug 28, 2018

# If not specified the DNS resolver will
# honour the TTL specified in the DNS record.
# If given, it will override the TTL for any
# valid record received.

This comment has been minimized.

Copy link
@thibaultcha

thibaultcha Aug 28, 2018

Member

This description is somewhat confusing to me. How about a more concise approach, less repetitive:

By default, DNS records are cached using the TTL value
of a response. If this property receives a value (in seconds),
it will override the TTL for all records.
@@ -28,7 +28,7 @@ dependencies = {
"luaossl == 20171028",
"luasyslog == 1.0.0",
"lua_pack == 1.0.5",
"lua-resty-dns-client == 2.1.0",
"lua-resty-dns-client == 2.2.0",

This comment has been minimized.

Copy link
@thibaultcha

thibaultcha Aug 28, 2018

Member

It would have been nice to split the bump and the feature into 2 separate commits :)

On top of the commit atomicity benefits, we would likely avoid forgetting to update the documentation at release time (if you do not happen to do it by then), since a feat(conf) commit is quite visible when drafting the changelog.

This comment has been minimized.

Copy link
@Tieske

Tieske Aug 28, 2018

Author Member

yes, good point. Adjusted it.

@Tieske Tieske force-pushed the feat/ttl-override branch 2 times, most recently from 8f5dc75 to b263c52 Aug 28, 2018

feat(conf) introducing DNS ttl-override option
This exposes the new DNS option to override the DNS record
ttl to Kong.

@Tieske Tieske force-pushed the feat/ttl-override branch from b263c52 to 2b1e0ca Aug 28, 2018

thibaultcha added a commit that referenced this pull request Aug 28, 2018

thibaultcha added a commit that referenced this pull request Aug 28, 2018

feat(conf) introduce a new 'dns_valid_ttl' option
This exposes the new DNS option to override the DNS record TTL to Kong.

From #3730
@thibaultcha

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

@Tieske Thanks, merged!

@thibaultcha thibaultcha deleted the feat/ttl-override branch Aug 28, 2018

Tieske added a commit to Kong/docs.konghq.com that referenced this pull request Sep 4, 2018

Tieske added a commit that referenced this pull request Sep 5, 2018

Tieske added a commit that referenced this pull request Sep 5, 2018

feat(conf) introduce a new 'dns_valid_ttl' option
This exposes the new DNS option to override the DNS record TTL to Kong.

From #3730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.