Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) port plugins entities and Admin endpoints to the new DAO #3766

Merged
merged 13 commits into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@thibaultcha
Copy link
Member

thibaultcha commented Sep 13, 2018

Work from @kikito to port plugins entities over to the new DAO, to the exception of the OAuth2 plugin.

@thibaultcha thibaultcha force-pushed the feat/new-db-plugins-daos branch from a59dc35 to 1a0924e Sep 13, 2018

@thibaultcha

This comment has been minimized.

Copy link
Member Author

thibaultcha commented Sep 13, 2018

@kikito @hishamhm The branch has been rebased on top of next to resolve a few merge conflicts - please make sure to pull it if you are planning on making edits to it.

@hishamhm
Copy link
Member

hishamhm left a comment

LGTM — any questions I had earlier this week were already answered by @kikito, and I see the 02-api_spec was also deleted, so this looks good to go! Thanks @thibaultcha for rebasing and PRing this

@thibaultcha thibaultcha merged commit 99c81b4 into next Sep 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thibaultcha thibaultcha deleted the feat/new-db-plugins-daos branch Sep 14, 2018

@thibaultcha

This comment has been minimized.

Copy link
Member Author

thibaultcha commented Sep 14, 2018

Merged with merge commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.