Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/plugins code to new db #3839

Merged
merged 4 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@kikito
Copy link
Member

kikito commented Oct 9, 2018

Replaces usage of old-style DAO with new-style db in all plugins:

  • Noticed a bug in the ACL plugin cache invalidation code. Fixed here.
  • The main purpose of this task was replacing singletons.dao with calls to kong.db. I also replaced singletons.cache with kong.cache and singletons.configuration with kong.configuration.
@hishamhm
Copy link
Member

hishamhm left a comment

Just left a couple of minor questions there — once those are clarified I think it's good to go.

@kikito kikito force-pushed the feat/plugins-code-to-new-db branch from 3fa90a8 to af64679 Oct 16, 2018

@kikito kikito force-pushed the feat/plugins-code-to-new-db branch from af64679 to e136f6d Oct 16, 2018

@kikito kikito force-pushed the feat/plugins-code-to-new-db branch from e136f6d to abcc776 Oct 16, 2018

@hishamhm hishamhm added pr/ready and removed pr/discussion labels Oct 17, 2018

@hishamhm
Copy link
Member

hishamhm left a comment

LGTM!

@hishamhm hishamhm merged commit dc2be94 into next Oct 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hishamhm hishamhm deleted the feat/plugins-code-to-new-db branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.