Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db) add generate_admin_api schema option #3861

Merged

Conversation

Projects
None yet
3 participants
@james-callahan
Copy link
Contributor

james-callahan commented Oct 17, 2018

Still needs tests.

@bungle

This comment has been minimized.

Copy link
Member

bungle commented Oct 17, 2018

Can you elaborate about the context? It seems like a decent patch otherwise.

@james-callahan

This comment has been minimized.

Copy link
Contributor Author

james-callahan commented Oct 18, 2018

Can you elaborate about the context?

Sorry for not explaining; this patch came out of a phone call with @hishamhm.

We don't want to expose the new CA entity (see next...james-callahan:feat/mesh-ca-bootstrap) via the admin api. This PR introduces a flag to opt-out.

@thibaultcha thibaultcha merged commit c531749 into Kong:next Oct 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@james-callahan james-callahan deleted the james-callahan:feat/turn-off-adminapi-generation branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.