Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pdk) add consumer, service, route handling #3916

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@Tieske
Copy link
Member

Tieske commented Oct 26, 2018

  • Adds getters/setters to the PDK for the consumer (+credential), service, and route entities.
  • refactor plugins to use the new PDK functions

Replaces #3909

@Tieske Tieske self-assigned this Oct 26, 2018

@Tieske Tieske force-pushed the one-more-pdk branch from 537562a to b6ba71b Oct 26, 2018

@Tieske Tieske force-pushed the one-more-pdk branch from b6ba71b to 018bb87 Oct 26, 2018

Show resolved Hide resolved kong/pdk/client.lua Outdated

@Tieske Tieske force-pushed the one-more-pdk branch 2 times, most recently from 0025398 to 1d5e213 Oct 29, 2018

Show resolved Hide resolved kong/pdk/client.lua Outdated
Show resolved Hide resolved kong/pdk/client.lua Outdated
Show resolved Hide resolved kong/pdk/client.lua
feat(pdk) add consumer, service, route handling
Adds getters/setters to the PDK for the consumer (+credential),
service, and route entities.

@Tieske Tieske force-pushed the one-more-pdk branch from 1d5e213 to 3c9f3b2 Oct 31, 2018



---
-- Sets the authenticated consumer (and credential) for the current request.

This comment has been minimized.

Copy link
@kikito

kikito Nov 1, 2018

Member

I think the description should be Sets the authenticated consumer and/or credential. The current wording makes it sound like consumer is mandatory and credential is optional.

This comment has been minimized.

Copy link
@kikito

kikito Nov 1, 2018

Member

I think the description also needs to have a note "While both consumer and credential can be nil, it is required that at least one if them exists. Otherwise this function will throw an error".

@kikito

kikito approved these changes Nov 1, 2018

@Tieske Tieske force-pushed the one-more-pdk branch from 3c9f3b2 to 2ba6eec Nov 1, 2018

@Tieske Tieske merged commit 17916e3 into next Nov 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Tieske Tieske deleted the one-more-pdk branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.