Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cors) follow mozilla guidelines for preflight request #4029

Merged
merged 5 commits into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@aslafy-z
Copy link
Contributor

aslafy-z commented Nov 28, 2018

Summary

Follow the mozilla guidelines for preflight request (https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request) for the cors plugin implementation.

Full changelog

  • On OPTIONS requests
    • Send 200 instead of 204
    • Set Content-Length to 0

Issues resolved

Fixes #4008

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Nov 28, 2018

CLA assistant check
All committers have signed the CLA.

@aslafy-z aslafy-z force-pushed the aslafy-z:fix/cors-http-codes branch from 76f6736 to 05fa3d7 Nov 28, 2018

aslafy-z added some commits Nov 28, 2018

@aslafy-z aslafy-z force-pushed the aslafy-z:fix/cors-http-codes branch from 05fa3d7 to b89e799 Nov 28, 2018

@thibaultcha
Copy link
Member

thibaultcha left a comment

Thanks for the patch! Mind addressing the review?

Show resolved Hide resolved kong/plugins/cors/handler.lua Outdated

@thibaultcha thibaultcha added this to the 1.0.0rc4 milestone Nov 30, 2018

@thibaultcha thibaultcha merged commit da8b4c2 into Kong:next Nov 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@thibaultcha

This comment has been minimized.

Copy link
Member

thibaultcha commented Nov 30, 2018

Thank you! Don't forget to claim your Contributor T-shirt :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.