Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins) defend transformer plugins against possible errors and nil values #4038

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
4 participants
@hishamhm
Copy link
Member

commented Nov 30, 2018

Fixes by @bungle for request-transformer and response-transformer, defending them against possible errors and nil values. Cherry-picked from #3976.

@thibaultcha thibaultcha added this to the 1.0.0rc4 milestone Dec 1, 2018

@kikito

kikito approved these changes Dec 1, 2018

@kikito

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

I approved this in order to accelerate merging, but have one question: the spec-old-api specs have been removed. Does that belong here? I thought API-related code would be removed on its own PR.

@kikito kikito merged commit 920620c into next Dec 3, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.

@hishamhm hishamhm deleted the fix/response-transformer branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.