Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk) make kong.request.get_body() to return nil, err on simple json values #4063

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@bungle
Copy link
Member

bungle commented Dec 7, 2018

Summary

Changes kong.request.get_body() to return nil, err on application/json simple types as a root (and only) content:

  • strings
  • numbers
  • booleans
  • nulls

So you can after this is merged only use this to read following JSON content:

  • arrays
  • objects

as a root content.

Fix #4007

@bungle bungle requested a review from Tieske Dec 7, 2018

@bungle bungle force-pushed the fix/pdk-request-get-body branch from 1df1f8f to 9113bd5 Dec 7, 2018

@Tieske
Copy link
Member

Tieske left a comment

why the change to oauth2/access.lua?

@thibaultcha thibaultcha merged commit 3b550b5 into next Dec 7, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.

@thibaultcha thibaultcha deleted the fix/pdk-request-get-body branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.