Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) enable plugin.run_on support on plugins iterator #4066

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
5 participants
@bungle
Copy link
Member

commented Dec 7, 2018

Summary

This will add support for run_on attribute on Plugins to make them run on:

  1. all Kong nodes regardless
  2. first Kong node in gateway or service-mesh modes only
  3. second Kong node in service-mesh mode only

This is manually tested to be working with latest (not yet released) luaossl and our (released) openresty-patches, but this does not include busted tests yet. If that is a blocker for release of a release candidate, then I will update this PR on monday.

@bungle bungle requested review from james-callahan and thibaultcha Dec 7, 2018

Show resolved Hide resolved kong/runloop/plugins_iterator.lua Outdated
Show resolved Hide resolved kong/runloop/plugins_iterator.lua Outdated
Show resolved Hide resolved kong/runloop/handler.lua Outdated

@bungle bungle force-pushed the feat/plugins-iterator-run-on-support-only branch from 5ed8f28 to 1012f14 Dec 7, 2018

@thibaultcha

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

The chore commit can use the more descriptive scope perf.

@thibaultcha

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

@bungle bungle force-pushed the feat/plugins-iterator-run-on-support-only branch 2 times, most recently from e0a99c4 to 7699be7 Dec 8, 2018

@bungle bungle force-pushed the feat/plugins-iterator-run-on-support-only branch 2 times, most recently from 4c2044e to 19f4b0b Dec 10, 2018

issue is fixed.

@bungle bungle force-pushed the feat/plugins-iterator-run-on-support-only branch from 19f4b0b to 7be4ce2 Dec 10, 2018

@kikito

kikito approved these changes Dec 10, 2018

method = "GET",
path = "/status/200",
headers = {
["Host"] = "run-on-second.org",

This comment has been minimized.

Copy link
@james-callahan

james-callahan Dec 10, 2018

Contributor

Avoid potentially real domain names in tests? Can we prefer subdomains of example.com/org/net?

This comment has been minimized.

Copy link
@p0pr0ck5

p0pr0ck5 Dec 10, 2018

Contributor

+1 for example.com please

This comment has been minimized.

Copy link
@bungle

bungle Dec 10, 2018

Author Member

It already went in., sorry :-(.

@bungle bungle merged commit 115bc35 into next Dec 10, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.

@bungle bungle deleted the feat/plugins-iterator-run-on-support-only branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.