Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(core) enable plugin.run_on support on plugins iterator #4066
This will add support for
This is manually tested to be working with latest (not yet released)
Ok, no big deal! Let’s keep it as-is then.…
On Dec 8, 2018, at 10:29 AM, Aapo Talvensaari ***@***.***> wrote: @bungle commented on this pull request. In kong/runloop/plugins_iterator.lua: > @@ -45,7 +45,10 @@ local function load_plugin_configuration(ctx, return ngx.exit(ngx.ERROR) end - if plugin ~= nil and plugin.enabled then + if plugin ~= nil and plugin.enabled and (plugin.run_on == "all" or + (not ctx.is_service_mesh_request and plugin.run_on == "first") or + (ctx.is_service_mesh_request and plugin.run_on == "second")) then Just to align lines for readability, but I guess everyone sees this differently. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.