chore(ci) make sure tags dont get built by the nightly cron #5594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hutchic
commented
Feb 21, 2020
| @@ -1,17 +1,35 @@ | |||
| pipeline { | |||
| agent none | |||
| triggers { | |||
| cron(env.BRANCH_NAME == 'master' | env.BRANCH_NAME == 'next' ? '@daily' : '') | |||
| } | |||
There was a problem hiding this comment.
we may need to cherry-pick and push this line onto the 2.x tags
hutchic
commented
Feb 21, 2020
| anyOf { branch 'master'; branch 'next' } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
this evaluates to
if (
( buildingtag && not cron ) ||
( ( branch = master || branch = next) && cron )
)
There was a problem hiding this comment.
Please put that in a comment on the file, too.
kikito
approved these changes
Feb 25, 2020
| anyOf { branch 'master'; branch 'next' } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please put that in a comment on the file, too.
hutchic
added a commit
that referenced
this pull request
Feb 27, 2020
* chore(ci) make sure tags dont get built by the nightly cron * chore(doc) add a comment about the Jenkinsfile when logic
hutchic
added a commit
that referenced
this pull request
Feb 27, 2020
* chore(ci) make sure tags dont get built by the nightly cron * chore(doc) add a comment about the Jenkinsfile when logic
snt8amr
pushed a commit
to snt8amr/kong
that referenced
this pull request
May 30, 2020
* chore(ci) make sure tags dont get built by the nightly cron * chore(doc) add a comment about the Jenkinsfile when logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only two conditions in which Jenkins should be doing anything
Release:
Nightly Release:
SCM push to next / master is a noop
cron event runs build, test and nightly release stages
SCM tag runs build, test and nightly release stage also the tag doesn't attempt to re-run every 24hrs
