fix: broken log lines in ingress status #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
force-pushed
the
shaneutt/fix-status-updates
branch
from
30ed5e8
to
f8ee145
Compare
Turns out there were several ineffectual log entries that were causing an improper import of an unrelated dependency, this switches to using logr in all those places.
shaneutt
force-pushed
the
shaneutt/fix-status-updates
branch
from
f8ee145
to
119e926
Compare
This was referenced Oct 19, 2021
rainest
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Turns out there were several ineffectual log entries that were causing an improper import of an unrelated dependency and making it difficult to debug the status updates code. This switches to using logr in all those places, enables debug level appropriately, and fixes up formatting and data for several of the log entries. These problems were making it particularly hard to debug #1925.
Which issue this PR fixes
Partially resolves #1925
PR Readiness Checklist:
CHANGELOG.mdrelease notes have been updated