Permalink
Browse files

Closed TODOs in config module

  • Loading branch information...
1 parent a7ec6cc commit 24739dff56f7a338ab57e5892766a04096db2470 @KonishchevDmitry committed Dec 18, 2012
Showing with 3 additions and 10 deletions.
  1. +3 −10 pyvsb/config.py
View
@@ -1,4 +1,3 @@
-# TODO: check errors
"""pyvsb configuration file parser."""
import copy
@@ -9,9 +8,6 @@
from .core import Error
-# TODO: HERE
-#os.path.realpath(
-# != "/"
def get_config(path):
"""Parses the configuration file."""
@@ -23,19 +19,17 @@ def get_config(path):
config = {}
_get_param(config_obj, config, "backup_root", str, validate = _validate_path)
- _get_param(config_obj, config, "backup_items", dict,
- validate = _validate_backup_items)
+ _get_param(config_obj, config, "backup_items", dict, validate = _validate_backup_items)
_get_param(config_obj, config, "max_backups", int, validate = _validate_positive_integer)
_get_param(config_obj, config, "max_backup_groups", int, validate = _validate_positive_integer)
- _get_param(config_obj, config, "trust_modify_time", bool, default = True) # TODO
- _get_param(config_obj, config, "preserve_hard_links", bool, default = True) # TODO
+ _get_param(config_obj, config, "trust_modify_time", bool, default = True)
+ _get_param(config_obj, config, "preserve_hard_links", bool, default = True)
return config
-# TODO: HERE
def _get_param(config_obj, config, name, value_type, default = None, validate = lambda value: value):
"""Gets the specified parameter from config."""
@@ -58,7 +52,6 @@ def _get_param(config_obj, config, name, value_type, default = None, validate =
raise Error("Invalid {} value: {}", config_name, e)
-# TODO: HERE
def _validate_backup_items(backup_items):
"""Validates backup items."""

0 comments on commit 24739df

Please sign in to comment.