Better support for input submissions#157
Merged
KonnorRogers merged 10 commits intoKonnorRogers:mainfrom Oct 25, 2021
Merged
Conversation
- Support json, escaped json, and url-encoded formats for data-params - Submit element's name and value
|
✔️ Deploy Preview for mrujs canceled. 🔨 Explore the source changes: 948a633 🔍 Inspect the deploy log: https://app.netlify.com/sites/mrujs/deploys/6174c3e38dd80d000751dd71 |
rickychilcott
force-pushed
the
support-all-ujs-param-formats
branch
from
c181b4d to
79ad7d3
Compare
Owner
KonnorRogers
left a comment
KonnorRogers
left a comment
There was a problem hiding this comment.
This looks prettty good! I'm probably going to refactor and add some base cases! Thank you for taking the time! Most of the review here is nit picky stuff more than anything (mostly for future me, or you if you'd prefer!)
…d params and then utilize throughout `parseParamFormats`
… since Object.entries on top of return values from `parseParamFormats`
KonnorRogers
approved these changes
Oct 25, 2021
Owner
KonnorRogers
left a comment
KonnorRogers
left a comment
There was a problem hiding this comment.
Thank you so much for this @rickychilcott !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Additional Notes
I don't know TS very well and I haven't been able to test on my app because I can't figure out how to get a local version of mrujs running locally on my project. Directions on how to do that would be helpful.
This is mostly a WIP but should support multiple formats and get us close to full
data-paramssupport.