Deprecation Notice: Koodimonni\Composer\Dropin::onPackageInstall #9

Closed
grappler opened this Issue Jan 3, 2017 · 1 comment

Projects

None yet

2 participants

@grappler
grappler commented Jan 3, 2017

I am getting the following deprecation notice while running koodimonni/composer-dropin-installer from masterand composer v1.3.0.

Deprecation Notice: The callback Koodimonni\Composer\Dropin::onPackageInstall declared at /vendor/koodimonni/composer-dropin-installer/src/Dropin.php accepts a Composer\Script\PackageEvent but post-package-install events use a Composer\Installer\PackageEvent instance.
Please adjust your type hint accordingly, see https://getcomposer.org/doc/articles/scripts.md#event-classes in composer/1.3.0/libexec/composer.phar/src/Composer/EventDispatcher/EventDispatcher.php:317

@onnimonni
Contributor

Thanks for reporting. I think this can be easily fixed just by changing Composer\Script\PackageEvent -> Composer\Installer\PackageEvent everywhere in the plugin.

It would be awesome If you can test this and create a pull request.

@onnimonni onnimonni pushed a commit that closed this issue Jan 11, 2017
@Bogstag Bogstag Update to fix #9 Deprecation Notice
Replaced Composer\Script\PackageEvent with Composer\Installer\PackageEvent
1f8abe9
@onnimonni onnimonni closed this in 1f8abe9 Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment