Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port parshah code from C #134

Merged
merged 1 commit into from Aug 23, 2019
Merged

port parshah code from C #134

merged 1 commit into from Aug 23, 2019

Conversation

@yparitcher
Copy link
Contributor

yparitcher commented Jan 18, 2019

this is a port of the parshah code from my C hebrew date & zmanim program libzmanim

@KosherJava

This comment has been minimized.

Copy link
Owner

KosherJava commented Aug 22, 2019

@yparitcher I know that it has been a long time. I had planned on refactoring things, but I see that will delay this too much, and I can easily do it after this is added. One small change request I have is the parsha names in the enums. Can you use the Ashkenazi transliteration as used throughout the codebase. Specifically see 5c14a07#diff-70152126b02d93ec0863fe69964ff69b
Thanks

@yparitcher yparitcher force-pushed the yparitcher:parshah branch from 141327f to 1b97526 Aug 22, 2019
@yparitcher

This comment has been minimized.

Copy link
Contributor Author

yparitcher commented Aug 22, 2019

fixed

Copy link
Owner

KosherJava left a comment

Thank you @yparitcher for this PR that restores parsha functionality.

@KosherJava KosherJava merged commit d666470 into KosherJava:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.