Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upport parshah code from C #134
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
@yparitcher I know that it has been a long time. I had planned on refactoring things, but I see that will delay this too much, and I can easily do it after this is added. One small change request I have is the parsha names in the enums. Can you use the Ashkenazi transliteration as used throughout the codebase. Specifically see 5c14a07#diff-70152126b02d93ec0863fe69964ff69b |
This comment has been minimized.
This comment has been minimized.
|
fixed |
|
Thank you @yparitcher for this PR that restores parsha functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yparitcher commentedJan 18, 2019
this is a port of the parshah code from my C hebrew date & zmanim program libzmanim