Skip to content


Browse files Browse the repository at this point in the history
fix(position): remove useless altitude argument
BREAKING CHANGE: invoking kosmorro command with the --altitude argument
will now fail with an "unrecognized arguments" error.
  • Loading branch information
Jérôme Deuchnord committed Dec 1, 2019
1 parent 445c04b commit d079fc7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions kosmorro
Expand Up @@ -40,7 +40,7 @@ def main():
if day is not None and month is None:
month =

ephemeris = EphemeridesComputer(Position(args.latitude, args.longitude, altitude=args.altitude))
ephemeris = EphemeridesComputer(Position(args.latitude, args.longitude))
ephemerides = ephemeris.compute_ephemerides(year, month, day)

dump = output_formats[args.format](ephemerides, date(year, month, day))
Expand Down Expand Up @@ -84,7 +84,7 @@ def get_args(output_formats: [str]):
parser = argparse.ArgumentParser(description='Compute the ephemerides for a given date, at a given position'
' on Earth.',
epilog='By default, the ephemerides will be computed for today (%s) for an'
' observer positioned at coordinates (0,0), with an altitude of 0.'
' observer positioned at coordinates (0,0).'
% today.strftime('%a %b %d, %Y'))

parser.add_argument('--version', '-v', dest='special_action', action='store_const', const=output_version,
Expand All @@ -97,8 +97,6 @@ def get_args(output_formats: [str]):
help="The observer's latitude on Earth")
parser.add_argument('--longitude', '-lon', type=float, default=0.,
help="The observer's longitude on Earth")
parser.add_argument('--altitude', '-alt', type=float, default=0.,
help="The observer's altitude on Earth")
parser.add_argument('--day', '-d', type=int,,
help='A number between 1 and 28, 29, 30 or 31 (depending on the month). The day you want to '
' compute the ephemerides for. Defaults to %d (the current day).' %
Expand Down
3 changes: 1 addition & 2 deletions kosmorrolib/
Expand Up @@ -61,10 +61,9 @@ def get_next_phase(self):

class Position:
def __init__(self, latitude: float, longitude: float, altitude: float = 0):
def __init__(self, latitude: float, longitude: float):
self.latitude = latitude
self.longitude = longitude
self.altitude = altitude
self.observation_planet = None

def get_planet_topos(self) -> Topos:
Expand Down

0 comments on commit d079fc7

Please sign in to comment.