Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the data #129

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Refactor the data #129

merged 1 commit into from
Dec 11, 2020

Conversation

Deuchnord
Copy link
Member

Q A
Bug fix? no
New feature? no
Related issues N/D
Has BC-break yes
License GNU AGPL-v3

Checklist:

  • I have updated the manpages

@Deuchnord Deuchnord self-assigned this Dec 1, 2020
@Deuchnord Deuchnord added the enhancement New feature or request label Dec 1, 2020
@Deuchnord Deuchnord changed the title refactor: use enum instead of dicts for the events and moon phase Refactor the data Dec 2, 2020
@Deuchnord Deuchnord force-pushed the refactor-events branch 12 times, most recently from c4c8b45 to 52a0c46 Compare December 2, 2020 10:15
@Deuchnord Deuchnord marked this pull request as ready for review December 2, 2020 13:14
Copy link
Member Author

@Deuchnord Deuchnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just giving myself a review for the future me.

.github/workflows/i18n.yml Outdated Show resolved Hide resolved
BREAKING CHANGE: some methodes in Event and MoonPhase have been dropped
in favor of `enum.Enum`'s `name` and `value` properties.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 79.721% when pulling 6a2999f on refactor-events into da436f9 on features.

@Deuchnord Deuchnord merged commit c00f6e8 into features Dec 11, 2020
@Deuchnord Deuchnord deleted the refactor-events branch December 11, 2020 09:17
Deuchnord added a commit that referenced this pull request Jan 22, 2021
…#129)

BREAKING CHANGE: some methodes in Event and MoonPhase have been dropped
in favor of `enum.Enum`'s `name` and `value` properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants