Skip to content

fix: fix localization for Earth and apsis #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2022
Merged

fix: fix localization for Earth and apsis #275

merged 3 commits into from
Jul 7, 2022

Conversation

Deuchnord
Copy link
Member

Q A
Bug fix? yes
New feature? no
Related issues
Has BC-break no
License GNU AGPL-v3

Checklist:

  • I have updated the manpages
  • Current wording "apogee" and "perigee" is too specific to the Moon. It is not adapted to the Earth. Using the more generic periapsis and apoapsis instead (see Apsis on Wikipedia for more details)
  • Add missing string for the Earth (fixes the "None is at its apogee (sic)" issue)

@Deuchnord Deuchnord changed the title Fix/earth localization fix: fix localization for Earth ans apsis Jul 7, 2022
@Deuchnord Deuchnord changed the title fix: fix localization for Earth ans apsis fix: fix localization for Earth and apsis Jul 7, 2022
@Deuchnord Deuchnord force-pushed the fix/earth-localization branch from b240b0a to e13718e Compare July 7, 2022 11:11
@Deuchnord Deuchnord marked this pull request as ready for review July 7, 2022 11:51
@Deuchnord Deuchnord merged commit 1f1118c into master Jul 7, 2022
@Deuchnord Deuchnord deleted the fix/earth-localization branch July 7, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Deuchnord