Skip to content

Search for working gh client.#199

Merged
KostyaSha merged 14 commits into
masterfrom
resolver
Feb 23, 2017
Merged

Search for working gh client.#199
KostyaSha merged 14 commits into
masterfrom
resolver

Conversation

@KostyaSha

@KostyaSha KostyaSha commented Feb 8, 2017

Copy link
Copy Markdown
Owner

closes #198


This change is Reviewable

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
@codecov-io

codecov-io commented Feb 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #199 into master will decrease coverage by -0.17%.

@@             Coverage Diff              @@
##             master     #199      +/-   ##
============================================
- Coverage     54.81%   54.65%   -0.17%     
+ Complexity      583      574       -9     
============================================
  Files           110      109       -1     
  Lines          2866     2847      -19     
  Branches        231      229       -2     
============================================
- Hits           1571     1556      -15     
+ Misses         1210     1207       -3     
+ Partials         85       84       -1
Impacted Files Coverage Δ Complexity Δ
...asha/github/integration/generic/GitHubTrigger.java 85% <100%> (ø) 28 <ø> (ø)
...generic/repoprovider/GitHubPluginRepoProvider.java 70.58% <42.85%> (-2.75%) 11 <1> (+1)
...lugins/github/pullrequest/GitHubPRPullRequest.java 77.14% <ø> (-0.33%) 24% <ø> (-4%)
...ci/plugins/github/pullrequest/GitHubPRTrigger.java 71.42% <ø> (ø) 18% <ø> (-1%)
...ration/generic/utils/RetryableGitHubOperation.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a3308...0d08242. Read the comment docs.

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
@codecov-io

codecov-io commented Feb 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #199 into master will increase coverage by 0.48%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #199      +/-   ##
============================================
+ Coverage     54.81%   55.29%   +0.48%     
- Complexity      583      624      +41     
============================================
  Files           110      114       +4     
  Lines          2866     3038     +172     
  Branches        231      246      +15     
============================================
+ Hits           1571     1680     +109     
- Misses         1210     1262      +52     
- Partials         85       96      +11
Impacted Files Coverage Δ Complexity Δ
...neric/errors/impl/GitHubHookRegistrationError.java 0% <ø> (ø) 0 <ø> (?)
...github/integration/branch/GitHubBranchTrigger.java 62.72% <10%> (-3.62%) 17 <ø> (ø)
...asha/github/integration/generic/GitHubTrigger.java 87.09% <100%> (+2.09%) 31 <9> (+3)
...integration/generic/errors/GitHubErrorsAction.java 41.66% <41.66%> (ø) 6 <6> (?)
...n/generic/errors/impl/GitHubRepoProviderError.java 66.66% <66.66%> (ø) 1 <1> (?)
...generic/repoprovider/GitHubPluginRepoProvider.java 75% <69.23%> (+1.66%) 12 <2> (+2)
...github/integration/generic/errors/GitHubError.java 75% <75%> (ø) 1 <1> (?)
...ci/plugins/github/pullrequest/GitHubPRTrigger.java 68.96% <8.33%> (-2.47%) 29 <ø> (+10)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a3308...ee57d95. Read the comment docs.

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
@KostyaSha KostyaSha modified the milestones: 0.1.0-rc20, 0.1.0-rc21 Feb 23, 2017
@KostyaSha KostyaSha merged commit cc68edd into master Feb 23, 2017
@KostyaSha KostyaSha deleted the resolver branch June 7, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find GH repo provider if correct credentials are not set as first "Server" in global config

2 participants