Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render platform tabs for common-only content #2613

merged 3 commits into from Aug 17, 2022


Copy link

See #2576

The main idea is that declarations without platform tabs can be considered to be "common" by default

The problem with rendering single "common" platform tab everywhere is that it attracts too much attention with the current changes, but doesn't bring that much value. This ought to make package overview page more minimalistic.

Comment on lines +956 to +957
.table-row .platform-hinted .sourceset-dependent-content .brief,
.table-row .platform-hinted .sourceset-dependent-content .inline-comment {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there's no tabs, now content is rendered the same way as for single platform projects, and there's currently a visual problem - no padding between paragraphs. See this page for instance

This should solve it for both single and multi platform pages

@IgnatBeresnev IgnatBeresnev mentioned this pull request Aug 8, 2022
@IgnatBeresnev IgnatBeresnev merged commit e9e95f6 into master Aug 17, 2022
@IgnatBeresnev IgnatBeresnev deleted the common-tab-rendering branch August 17, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants