Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Provide inline overloads of terminal operators returning Nothing for SharedFlow #2502

Closed
LouisCAD opened this issue Jan 27, 2021 · 2 comments

Comments

@LouisCAD
Copy link
Contributor

@LouisCAD LouisCAD commented Jan 27, 2021

That would make it easier to mark functions that never return (responding only to cancellation after being called) because they collect an infinite flow.

@LouisCAD
Copy link
Contributor Author

@LouisCAD LouisCAD commented Mar 27, 2021

Should I send a PR?

@qwwdfsad qwwdfsad added the flow label Jun 8, 2021
@qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Jun 11, 2021

Sure 👍

qwwdfsad added a commit that referenced this issue Jul 1, 2021
    * Override will ensure the proper implementation of the interface
    * collect extension is added as the very basic lint helper

Fixes #2789
Fixes #2502
yorickhenning pushed a commit to yorickhenning/kotlinx.coroutines that referenced this issue Jan 28, 2022
Kotlin#2803)

* Introduce SharedFlow collect overload and override that return Nothing
* Override will ensure the proper implementation of the interface
* collect extension is added as the very basic lint helper

Fixes Kotlin#2789
Fixes Kotlin#2502

Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants