Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DisposableHandle fun interface, remove our own adapter #2790

Merged
merged 1 commit into from Sep 3, 2021

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Jun 25, 2021

It was internal and was not part of the ABI as it was internal.
So no existing code should break (well, except for those who called internal API via reflection) and source compatibility is preserved

@qwwdfsad qwwdfsad requested a review from dkhalanskyjb Jun 25, 2021
Copy link
Member

@dkhalanskyjb dkhalanskyjb left a comment

I checked to the best of my ability, and it does look like source-level compatibility is preserved.

@qwwdfsad
Copy link
Member Author

@qwwdfsad qwwdfsad commented Jun 25, 2021

Seems that ::DisposableHandle is not supported for fun interfaces, so let's postpone it for a while

@qwwdfsad qwwdfsad merged commit 61acb95 into develop Sep 3, 2021
1 check passed
@qwwdfsad qwwdfsad deleted the make-dh-fun branch Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants