Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limitedParallelism implementation on K/N #3226

Merged
merged 3 commits into from Mar 31, 2022
Merged

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Mar 29, 2022

The initial implementation predates new memory model and was never working on it

Fixes #3223

The initial implementation predates new memory model and was never working on it

Fixes #3223
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb Mar 29, 2022
}
val j2 = launch(view2) { j1.cancel() }
joinAll(j1, j2)
}
Copy link
Member

@dkhalanskyjb dkhalanskyjb Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: move this test to the JS source-set, and move the testTaskFairness test from the JVM source-set to concurrent. This way, there will still be two versions of the test, but each one will be the most specific one for each target.

Copy link
Member Author

@qwwdfsad qwwdfsad Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left this one as is to still have common coverage and added test with newSingleThreadContext to concurrent source set. Juggled with names a bit as well

Copy link
Member

@dkhalanskyjb dkhalanskyjb Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I think having this test looks confusing. Maybe add a comment?

Copy link
Member Author

@qwwdfsad qwwdfsad Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@qwwdfsad qwwdfsad requested a review from dkhalanskyjb Mar 30, 2022
@qwwdfsad qwwdfsad force-pushed the fix-limited-parallelism branch from 3ddac07 to 135a3e6 Compare Mar 30, 2022
@qwwdfsad qwwdfsad merged commit 8133c97 into develop Mar 31, 2022
1 check passed
@qwwdfsad qwwdfsad deleted the fix-limited-parallelism branch Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants