Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a bigger opportunity window for cancellation in our flaky tests #3301

Merged
merged 1 commit into from
May 24, 2022

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented May 23, 2022

Attempt to fix our flaky test by giving cancellation more chances to kick in.

On windows, timed park is implemented via WaitForSingleObject that is known for having resolution issues because it relies on hardware interrupts under the hood, so timing is both frequency and machine-load sensitive, which is apparently the case on our Windows agents

@qwwdfsad qwwdfsad marked this pull request as ready for review May 23, 2022 20:18
@qwwdfsad qwwdfsad merged commit c5b5c66 into develop May 24, 2022
@qwwdfsad qwwdfsad deleted the attempt-to-fix-delay-test branch May 24, 2022 12:17
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants