Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate JsonPath into exception messages

Merged
merged 6 commits into from May 11, 2022
Merged

Incorporate JsonPath into exception messages #1841

merged 6 commits into from May 11, 2022

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Jan 24, 2022

While figuring out what to do with polymorphism I've come to the conclusion that #1839 have to be done, otherwise the change is way too widespread and intrusive while being really hard to maintain, so I've reverted this work halfway through and stopped on this

@qwwdfsad
Copy link
Member Author

qwwdfsad commented Jan 24, 2022

The latest commit is kinda controversial, it seems like we have to make #1266 finally public for both usage and construction

@qwwdfsad qwwdfsad requested review from sandwwraith and removed request for sandwwraith Jan 24, 2022
@qwwdfsad qwwdfsad requested a review from sandwwraith Jan 24, 2022
@qwwdfsad qwwdfsad force-pushed the json-path branch 2 times, most recently from 358e1a5 to 85dce74 Compare Mar 21, 2022
@qwwdfsad qwwdfsad requested a review from sandwwraith Mar 22, 2022
@sandwwraith sandwwraith merged commit fb02e66 into dev May 11, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants