Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of @ExperimentalUnsignedTypes on our declarations that levera… #1962

Merged
merged 4 commits into from Jun 24, 2022

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Jun 3, 2022

…ge non-experimental unsigned types

@qwwdfsad qwwdfsad requested a review from sandwwraith Jun 3, 2022
@qwwdfsad
Copy link
Member Author

qwwdfsad commented Jun 3, 2022

Also, it seems like it's time to lift experimentality as well, @sandwwraith are you aware of any blockers or open (design) issues for this?

@sandwwraith
Copy link
Member

sandwwraith commented Jun 3, 2022

I think we can remove experimentality, I don't remember any problems with them

@qwwdfsad
Copy link
Member Author

qwwdfsad commented Jun 3, 2022

I'll do it in a separate PR then

Copy link
Member

@sandwwraith sandwwraith left a comment

We also need to change a bit of documentation here:

> Experimental unsigned numbers as well as other experimental inline classes are not supported by Kotlin Serialization yet.

@qwwdfsad qwwdfsad requested a review from sandwwraith Jun 14, 2022
@sandwwraith
Copy link
Member

sandwwraith commented Jun 15, 2022

Do you plan to change docs/builtin-classes.md in this or in separate PR?

qwwdfsad added 2 commits Jun 24, 2022
# Conflicts:
#	core/commonMain/src/kotlinx/serialization/builtins/BuiltinSerializers.kt
#	core/commonMain/src/kotlinx/serialization/internal/ValueClasses.kt
#	formats/json/commonMain/src/kotlinx/serialization/json/internal/Composers.kt
#	formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonEncoder.kt
#	formats/json/commonTest/src/kotlinx/serialization/features/inline/EncodeInlineElementTest.kt
@qwwdfsad qwwdfsad merged commit 605a35f into dev Jun 24, 2022
@qwwdfsad qwwdfsad deleted the experimental-unsigned branch Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants