-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of @ExperimentalUnsignedTypes on our declarations that levera… #1962
Conversation
…ge non-experimental unsigned types
Also, it seems like it's time to lift experimentality as well, @sandwwraith are you aware of any blockers or open (design) issues for this? |
I think we can remove experimentality, I don't remember any problems with them |
I'll do it in a separate PR then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to change a bit of documentation here:
> Experimental unsigned numbers as well as other experimental inline classes are not supported by Kotlin Serialization yet. |
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Show resolved
Hide resolved
Do you plan to change |
# Conflicts: # core/commonMain/src/kotlinx/serialization/builtins/BuiltinSerializers.kt # core/commonMain/src/kotlinx/serialization/internal/ValueClasses.kt # formats/json/commonMain/src/kotlinx/serialization/json/internal/Composers.kt # formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonEncoder.kt # formats/json/commonTest/src/kotlinx/serialization/features/inline/EncodeInlineElementTest.kt
…ge non-experimental unsigned types