Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved okio support #1982

Merged
merged 5 commits into from Jul 12, 2022
Merged

Improved okio support #1982

merged 5 commits into from Jul 12, 2022

Conversation

shanshin
Copy link
Contributor

@shanshin shanshin commented Jul 6, 2022

  • when encoding and decoding, only BufferedSink/BufferedSource are used to eliminate ambiguities
  • at the end of encoding, emitCompleteSegments is called instead of flash for BufferedSink
  • internal extension functions changed to @PublishedApi + internal

- when encoding and decoding, only BufferedSink/BufferedSource are used to eliminate ambiguities
- at the end of encoding, emitCompleteSegments is called instead of flash for BufferedSink
- internal extension functions changed to @PublishedApi + internal
@shanshin shanshin requested review from qwwdfsad and sandwwraith Jul 6, 2022
@shanshin shanshin requested a review from sandwwraith Jul 10, 2022
@shanshin shanshin merged commit df3a161 into dev Jul 12, 2022
3 checks passed
@shanshin shanshin deleted the okio-improve branch Jul 12, 2022
martinbonnin added a commit to martinbonnin/kotlinx.serialization that referenced this pull request Jul 20, 2022
Follow up from Kotlin#1982. Since a `BufferedSink` is now required, no need to add this in the documentation.
@martinbonnin martinbonnin mentioned this pull request Jul 20, 2022
sandwwraith pushed a commit that referenced this pull request Jul 21, 2022
Follow up from #1982. Since a `BufferedSink` is now required, no need to add this in the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants