Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the website's release step in the release guide #2009

Merged
merged 1 commit into from Aug 17, 2022

Conversation

nikpachoo
Copy link
Contributor

@nikpachoo nikpachoo commented Aug 9, 2022

No description provided.

RELEASING.md Outdated
* Set new value for [`kotlinx.serialization.release.tag`](https://buildserver.labs.intellij.net/admin/editProject.html?projectId=Kotlin_KotlinSites_Builds_KotlinlangOrg_LibrariesAPIs&tab=projectParams)
* And run deploy [configuration](https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinSites_Builds_KotlinlangOrg_KotlinSerializationApi?branch=%3Cdefault%3E&mode=builds)
5. Propose the website documentation update:<br>
* Set new value for [`KOTLINX_SERIALIZATION_RELEASE_TAG`](https://github.com/JetBrains/kotlin-web-site/blob/master/.teamcity/BuildParams.kt), creating a Pull Request in the website's repository.
Copy link
Member

@sandwwraith sandwwraith Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what happens after the PR creation. Should releaser wait for PR to be merged or website build is started right away? If the latter, can PR be closed without merging then?

Copy link
Contributor Author

@nikpachoo nikpachoo Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. Please, review the updates.

@nikpachoo nikpachoo force-pushed the ktl-695-update-website-release-step-guide branch from ef78107 to cd9bd72 Compare Aug 11, 2022
@sandwwraith sandwwraith merged commit 738d131 into master Aug 17, 2022
3 checks passed
@sandwwraith sandwwraith deleted the ktl-695-update-website-release-step-guide branch Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants