Support standard HTML attributes in text inputs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nandoflorestan
commented
Sep 3, 2012
nandoflorestan
commented
- Supports the maxlength attribute via widget.maxlength
- Supports the HTML5 placeholder attribute via widget.placeholder
- Sets the HTML5 required="required" attribute if field.required
- Supports the *maxlength* attribute via widget.maxlength - Supports the HTML5 *placeholder* attribute via widget.placeholder - Sets the HTML5 required="required" attribute if field.required
|
Shouldn't this one be fixed upstream? |
|
Yes. It should. No response here, but @nandoflorestan opened Pylons/deform#116 You should close this. |
|
I agree that it is better if this is fixed in deform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.