local variable 'lower_guess' referenced before assignment #307

Closed
jgelens opened this Issue Apr 1, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@jgelens

jgelens commented Apr 1, 2016

The following error occured using 0.26. Version 0.25 was working fine.

File "python2.7/site-packages/weasyprint/layout/tables.py", line 582, in auto_table_layout
    if upper_guess == lower_guess:
UnboundLocalError: local variable 'lower_guess' referenced before assignment

@liZe

This comment has been minimized.

Show comment
Hide comment
@liZe

liZe Apr 1, 2016

Member

@jgelens thank you for your report. Could you please provide a example of HTML/CSS raising this error?

Member

liZe commented Apr 1, 2016

@jgelens thank you for your report. Could you please provide a example of HTML/CSS raising this error?

@liZe liZe added crash bug labels Apr 1, 2016

@jgelens

This comment has been minimized.

Show comment
Hide comment
@jgelens

jgelens Apr 1, 2016

Thanks for quick reply. I pasted the HTML here: http://pastebin.com/FJJqRkRB

jgelens commented Apr 1, 2016

Thanks for quick reply. I pasted the HTML here: http://pastebin.com/FJJqRkRB

@liZe liZe self-assigned this Apr 1, 2016

@liZe liZe closed this in 9556bf5 Apr 1, 2016

@liZe

This comment has been minimized.

Show comment
Hide comment
@liZe

liZe Apr 1, 2016

Member

It was SO FUN to debug 😄, a lot of interesting corner cases in a single bug report, I've had a good time, thank you!

(A real table-Jedi I'm becoming. Zviou Zviou.)

I've added a lot of tests, I hope that it'll cover all the strange cases like this one.

Member

liZe commented Apr 1, 2016

It was SO FUN to debug 😄, a lot of interesting corner cases in a single bug report, I've had a good time, thank you!

(A real table-Jedi I'm becoming. Zviou Zviou.)

I've added a lot of tests, I hope that it'll cover all the strange cases like this one.

@jgelens

This comment has been minimized.

Show comment
Hide comment
@jgelens

jgelens Apr 1, 2016

wow great, you're fast :-D Not perfect HTML/CSS is kinda tricky I guess. Thanks a lot for your great lib. Will you do a new release soonish or shall I try it with the git master?

jgelens commented Apr 1, 2016

wow great, you're fast :-D Not perfect HTML/CSS is kinda tricky I guess. Thanks a lot for your great lib. Will you do a new release soonish or shall I try it with the git master?

@liZe

This comment has been minimized.

Show comment
Hide comment
@liZe

liZe Apr 8, 2016

Member

0.27 will be released today.

Member

liZe commented Apr 8, 2016

0.27 will be released today.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jan 15, 2017

kleink
Update py-weasyprint to 0.34.
Version 0.34
------------

Released on 2016-12-21.

Bug fixes:

* `#398 <Kozea/WeasyPrint#398>`_:
  Honor the presentational_hints option for PDFs.
* `#399 <Kozea/WeasyPrint#399>`_:
  Avoid CairoSVG-2.0.0rc* on Python 2.
* `#396 <Kozea/WeasyPrint#396>`_:
  Correctly close files open by mkstemp.
* `#403 <Kozea/WeasyPrint#403>`_:
  Cast the number of columns into int.
* Fix multi-page multi-columns and add related tests.


Version 0.33
------------

Released on 2016-11-28.

New features:

* `#393 <Kozea/WeasyPrint#393:
  Add tests on MacOS.
* `#370 <Kozea/WeasyPrint#370>`_:
  Enable @font-face on MacOS.

Bug fixes:

* `#389 <Kozea/WeasyPrint#389>`_:
  Always update resume_at when splitting lines.
* `#394 <Kozea/WeasyPrint#394>`_:
  Don't build universal wheels.
* `#388 <Kozea/WeasyPrint#388>`_:
  Fix logic when finishing block formatting context.


Version 0.32
------------

Released on 2016-11-17.

New features:

* `#28 <Kozea/WeasyPrint#28>`_:
  Support @font-face on Linux.
* Support CSS fonts level 3 almost entirely, including OpenType features.
* `#253 <Kozea/WeasyPrint#253>`_:
  Support presentational hints (optional).
* Support break-after, break-before and break-inside for pages and columns.
* `#384 <Kozea/WeasyPrint#384:
  Major performance boost.

Bux fixes:

* `#368 <Kozea/WeasyPrint#368>`_:
  Respect white-space for shrink-to-fit.
* `#382 <Kozea/WeasyPrint#382>`_:
  Fix the preferred width for column groups.
* Handle relative boxes in column-layout boxes.

Documentation:

* Add more and more documentation about Windows installation.
* `#355 <Kozea/WeasyPrint#355:
  Add fonts requirements for tests.


Version 0.31
------------

Released on 2016-08-28.

New features:

* `#124 <Kozea/WeasyPrint#124>`_:
  Add MIME sniffing for images.
* `#60 <Kozea/WeasyPrint#60>`_:
  CSS Multi-column Layout.
* `#197 <Kozea/WeasyPrint#197>`_:
  Add hyphens at line breaks activated by a soft hyphen.

Bux fixes:

* `#132 <Kozea/WeasyPrint#132>`_:
  Fix Python 3 compatibility on Windows.

Documentation:

* `#329 <Kozea/WeasyPrint#329>`_:
  Add documentation about installation on Windows.


Version 0.30
------------

Released on 2016-07-18.

WeasyPrint now depends on html5lib-0.999999999.

Bux fixes:

* Fix Acid2
* `#325 <Kozea/WeasyPrint#325>`_:
  Cutting lines is broken in page margin boxes.
* `#334 <Kozea/WeasyPrint#334>`_:
  Newest html5lib 0.999999999 breaks rendering.


Version 0.29
------------

Released on 2016-06-17.

Bug fixes:

* `#263 <Kozea/WeasyPrint#263:
  Don't crash with floats with percents in positions.
* `#323 <Kozea/WeasyPrint#323>`_:
  Fix CairoSVG 2.0 pre-release dependency in Python 2.x.


Version 0.28
------------

Released on 2016-05-16.

Bug fixes:

* `#189 <Kozea/WeasyPrint#189>`_:
  ``white-space: nowrap`` still wraps on hyphens
* `#305 <Kozea/WeasyPrint#305>`_:
  Fix crashes on some tables
* Don't crash when transform matrix isn't invertible
* Don't crash when rendering ratio-only SVG images
* Fix margins and borders on some tables


Version 0.27
------------

Released on 2016-04-08.

New features:

* `#295 <Kozea/WeasyPrint#295>`_:
  Support the 'rem' unit.
* `#299 <Kozea/WeasyPrint#299>`_:
  Enhance the support of SVG images.

Bug fixes:

* `#307 <Kozea/WeasyPrint#307>`_:
  Fix the layout of cells larger than their tables.

Documentation:

* The website is now on GitHub Pages, the documentation is on Read the Docs.
* `#297 <Kozea/WeasyPrint#297>`_:
  Rewrite the CSS chapter of the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment