New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceWarning on python 3.6 with Warnings -W #746

Closed
Naddiseo opened this Issue Dec 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Naddiseo
Copy link
Contributor

Naddiseo commented Dec 4, 2018

In python 3.6 with warnings enabled, this line of __init__.py fails to close the file, and python complains about it being unclosed.

VERSION = __version__ = open(os.path.join(ROOT, 'VERSION')).read().strip()
[pid 20160:tid 140430425892608] [remote xxx:50794] ~/env/lib/python3.6/site-packages/weasyprint/__init__.py:42: ResourceWarning: unclosed file <_io.TextIOWrapper name='~/env/lib/python3.6/site-packages/weasyprint/VERSION' mode='r' encoding='ANSI_X3.4-1968'>

Naddiseo added a commit to Naddiseo/WeasyPrint that referenced this issue Dec 4, 2018

@liZe liZe closed this in #747 Dec 5, 2018

@liZe liZe added this to the 44 milestone Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment