Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: unsupported operand type(s) for +: 'float' and 'str' #831

Closed
vildric opened this issue Mar 21, 2019 · 4 comments

Comments

@vildric
Copy link

commented Mar 21, 2019

Issues #800 state that its fixed, but looks like it is not.

Django==1.11.16
WeasyPrint==46

  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/__init__.py", line 211, in write_pdf
    font_config=font_config).write_pdf(
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/__init__.py", line 168, in render
    font_config)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/document.py", line 366, in _render
    [Page(p, enable_hinting) for p in page_boxes],
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/document.py", line 366, in <listcomp>
    [Page(p, enable_hinting) for p in page_boxes],
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/__init__.py", line 133, in layout_document
    context, root_box, html, cascaded_styles, computed_styles, pages))
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/pages.py", line 807, in make_all_pages
    i, context, root_box, html, cascaded_styles, computed_styles)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/pages.py", line 744, in remake_page
    page_number, page_state)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/pages.py", line 555, in make_page
    positioned_boxes, positioned_boxes, adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 64, in block_level_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 80, in block_level_layout_switch
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 134, in block_box_layout
    page_is_empty, absolute_boxes, fixed_boxes, adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 515, in block_container_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 64, in block_level_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 80, in block_level_layout_switch
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 134, in block_box_layout
    page_is_empty, absolute_boxes, fixed_boxes, adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 515, in block_container_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 64, in block_level_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 95, in block_level_layout_switch
    device_size, page_is_empty, absolute_boxes, fixed_boxes)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/flex.py", line 128, in flex_layout
    child.position_y = parent_box.content_box_y()
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/formatting_structure/boxes.py", line 167, in content_box_y
    return self.position_y + self.margin_top + self.padding_top + \
TypeError: unsupported operand type(s) for +: 'float' and 'str'
@liZe liZe added the crash label Mar 22, 2019
@liZe

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Hello,

Could you please provide a HTML sample?

@picturedots

This comment has been minimized.

Copy link

commented May 16, 2019

You can reproduce the problem with:
weasyprint http://www.loan-street.com ./output.pdf

And here is the version that I used:

root@c9992a4b668c:/code# weasyprint --version
/usr/local/lib/python3.7/site-packages/weasyprint/document.py:34: UserWarning: There are known rendering problems and missing features with cairo < 1.15.4. WeasyPrint may work with older versions, but please read the note about the needed cairo version on the "Install" page of the documentation before reporting bugs. http://weasyprint.readthedocs.io/en/latest/install.html
  'There are known rendering problems and missing features with '
WeasyPrint version 47
@Tontyna

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

This is, similar to #910, another case of auto not being resolved to a pixel value. This time in the flex department. Snippet to reproduce the crash:

<style>
.flexcrash{
    margin-top: auto;
    display: flex;
}
</style>
<div class="flexcrash">
  XXX
</div>

Flex combined with a top margin of auto crashes, when Box.content_box_y tries to return self.position_y + self.margin_top + self.padding_top and can't add 'auto' to the floats.

Problem seems to be the BlockBox that WeasyPrint is forced to create as the child of the FlexBox (required by the XXX)

When the auto margins are applied to a separate child div, WeasyPrint doesn't crash:

<style>
.parent {
    display: flex;
    height:400px;
}
.child {
  margin: auto;
  background-color: red;
  width: 100px;
  height: 100px;    
}
</style>
<div class="parent">
<div class="child">
  XXX
</div>

Though it doesn't get the peculiar magic of flexbox and auto margins right -- the red square is centered horizontally but not vertically.

@liZe liZe closed this in 5f7a104 Sep 13, 2019
@liZe

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Auto margins on flex containers are now ignored. It's not a great solution, but at least it doesn't crash.

We should really add more tests for flexbox (#601) and fix the insane number of TODOs.

@liZe liZe added this to the 50 milestone Sep 13, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Oct 9, 2019
Version 50
----------

Released on 2019-09-19.

New features:

* `#209 <https://github.com/Kozea/WeasyPrint/issues/209>`_:
  Make ``break-*`` properties work inside tables
* `#661 <https://github.com/Kozea/WeasyPrint/issues/661>`_:
  Make blocks with ``overflow: auto`` grow to include floating children

Bug fixes:

* `#945 <https://github.com/Kozea/WeasyPrint/issues/945>`_:
  Don't break pages between a list item and its marker
* `#727 <https://github.com/Kozea/WeasyPrint/issues/727>`_:
  Avoid tables lost between pages
* `#831 <https://github.com/Kozea/WeasyPrint/issues/831>`_:
  Ignore auto margins on flex containers
* `#923 <https://github.com/Kozea/WeasyPrint/issues/923>`_:
  Fix a couple of crashes when splitting a line twice
* `#896 <https://github.com/Kozea/WeasyPrint/issues/896>`_:
  Fix skip stack order when using a reverse flex direction

Contributors:

- grewn0uille
- Guillaume Ayoub

Version 49
----------

Released on 2019-09-11.

Performance:

* Speed and memory use have been largely improved.

New features:

* `#700 <https://github.com/Kozea/WeasyPrint/issues/700>`_:
  Handle ``::marker`` pseudo-selector
* `135dc06c <https://github.com/Kozea/WeasyPrint/commit/135dc06c>`_:
  Handle ``recto`` and ``verso`` parameters for page breaks
* `#907 <https://github.com/Kozea/WeasyPrint/pull/907>`_:
  Provide a clean way to build layout contexts

Bug fixes:

* `#937 <https://github.com/Kozea/WeasyPrint/issues/937>`_:
  Fix rendering of tables with empty lines and rowspans
* `#897 <https://github.com/Kozea/WeasyPrint/issues/897>`_:
  Don't crash when small columns are wrapped in absolute blocks
* `#913 <https://github.com/Kozea/WeasyPrint/issues/913>`_:
  Fix a test about gradient colors
* `#924 <https://github.com/Kozea/WeasyPrint/pull/924>`_:
  Fix title for document with attachments
* `#917 <https://github.com/Kozea/WeasyPrint/issues/917>`_:
  Fix tests with Pango 1.44
* `#919 <https://github.com/Kozea/WeasyPrint/issues/919>`_:
  Fix padding and margin management for column flex boxes
* `#901 <https://github.com/Kozea/WeasyPrint/issues/901>`_:
  Fix width of replaced boxes with no intrinsic width
* `#906 <https://github.com/Kozea/WeasyPrint/issues/906>`_:
  Don't respect table cell width when content doesn't fit
* `#927 <https://github.com/Kozea/WeasyPrint/pull/927>`_:
  Don't use deprecated ``logger.warn`` anymore
* `a8662794 <https://github.com/Kozea/WeasyPrint/commit/a8662794>`_:
  Fix margin collapsing between caption and table wrapper
* `87d9e84f <https://github.com/Kozea/WeasyPrint/commit/87d9e84f>`_:
  Avoid infinite loops when rendering columns
* `789b80e6 <https://github.com/Kozea/WeasyPrint/commit/789b80e6>`_:
  Only use in flow children to set columns height
* `615e298a <https://github.com/Kozea/WeasyPrint/commit/615e298a>`_:
  Don't include floating elements each time we try to render a column
* `48d8632e <https://github.com/Kozea/WeasyPrint/commit/48d8632e>`_:
  Avoid not in flow children to compute column height
* `e7c452ce <https://github.com/Kozea/WeasyPrint/commit/e7c452ce>`_:
  Fix collapsing margins for columns
* `fb0887cf <https://github.com/Kozea/WeasyPrint/commit/fb0887cf>`_:
  Fix crash when using currentColor in gradients
* `f66df067 <https://github.com/Kozea/WeasyPrint/commit/f66df067>`_:
  Don't crash when using ex units in word-spacing in letter-spacing
* `c790ff20 <https://github.com/Kozea/WeasyPrint/commit/c790ff20>`_:
  Don't crash when properties needing base URL use var functions
* `d63eac31 <https://github.com/Kozea/WeasyPrint/commit/d63eac31>`_:
  Don't crash with object-fit: non images with no intrinsic size

Documentation:

* `#900 <https://github.com/Kozea/WeasyPrint/issues/900>`_:
  Add documentation about semantic versioning
* `#692 <https://github.com/Kozea/WeasyPrint/issues/692>`_:
  Add a snippet about PDF magnification
* `#899 <https://github.com/Kozea/WeasyPrint/pull/899>`_:
  Add .NET wrapper link
* `#893 <https://github.com/Kozea/WeasyPrint/pull/893>`_:
  Fixed wrong nested list comprehension example
* `#902 <https://github.com/Kozea/WeasyPrint/pull/902>`_:
  Add ``state`` to the ``make_bookmark_tree`` documentation
* `#921 <https://github.com/Kozea/WeasyPrint/pull/921>`_:
  Fix typos in the documentation
* `#328 <https://github.com/Kozea/WeasyPrint/issues/328>`_:
  Add CSS sample for forms

Contributors:

- grewn0uille
- Guillaume Ayoub
- Raphael Gaschignard
- Stani
- Szmen
- Thomas Dexter
- Tontyna

Version 48
----------

Released on 2019-07-08.

Dependencies:

* CairoSVG 2.4.0+ is now needed

New features:

* `#891 <https://github.com/Kozea/WeasyPrint/pull/891>`_:
  Handle ``text-overflow``
* `#878 <https://github.com/Kozea/WeasyPrint/pull/878>`_:
  Handle ``column-span``
* `#855 <https://github.com/Kozea/WeasyPrint/pull/855>`_:
  Handle all the ``text-decoration`` features
* `#238 <https://github.com/Kozea/WeasyPrint/issues/238>`_:
  Don't repeat background images when it's not needed
* `#875 <https://github.com/Kozea/WeasyPrint/issues/875>`_:
  Handle ``object-fit`` and ``object-position``
* `#870 <https://github.com/Kozea/WeasyPrint/issues/870>`_:
  Handle ``bookmark-state``

Bug fixes:

* `#686 <https://github.com/Kozea/WeasyPrint/issues/686>`_:
  Fix column balance when children are not inline
* `#885 <https://github.com/Kozea/WeasyPrint/issues/885>`_:
  Actually use the content box to resolve flex items percentages
* `#867 <https://github.com/Kozea/WeasyPrint/issues/867>`_:
  Fix rendering of KaTeX output, including (1) set row baseline of tables when
  no cells are baseline-aligned, (2) set baseline for inline tables, (3) don't
  align lines larger than their parents, (4) force CairoSVG to respect image
  size defined by CSS.
* `#873 <https://github.com/Kozea/WeasyPrint/issues/873>`_:
  Set a minimum height for empty list elements with outside marker
* `#811 <https://github.com/Kozea/WeasyPrint/issues/811>`_:
  Don't use translations to align flex items
* `#851 <https://github.com/Kozea/WeasyPrint/issues/851>`_,
  `#860 <https://github.com/Kozea/WeasyPrint/issues/860>`_:
  Don't cut pages when content overflows a very little bit
* `#862 <https://github.com/Kozea/WeasyPrint/issues/862>`_:
  Don't crash when using UTC dates in metadata

Documentation:

* `#854 <https://github.com/Kozea/WeasyPrint/issues/854>`_:
  Add a "Tips & Tricks" section

Contributors:

- Gabriel Corona
- Guillaume Ayoub
- Manuel Barkhau
- Nathan de Maestri
- grewn0uille
- theopeek

Version 47
----------

Released on 2019-04-12.

New features:

* `#843 <https://github.com/Kozea/WeasyPrint/pull/843>`_:
  Handle CSS variables
* `#846 <https://github.com/Kozea/WeasyPrint/pull/846>`_:
  Handle ``:nth()`` page selector
* `#847 <https://github.com/Kozea/WeasyPrint/pull/847>`_:
  Allow users to use a custom SSL context for HTTP requests

Bug fixes:

* `#797 <https://github.com/Kozea/WeasyPrint/issues/797>`_:
  Fix underlined justified text
* `#836 <https://github.com/Kozea/WeasyPrint/issues/836>`_:
  Fix crash when flex items are replaced boxes
* `#835 <https://github.com/Kozea/WeasyPrint/issues/835>`_:
  Fix ``margin-break: auto``

Version 46
----------

Released on 2019-03-20.

New features:

* `#771 <https://github.com/Kozea/WeasyPrint/issues/771>`_:
  Handle ``box-decoration-break``
* `#115 <https://github.com/Kozea/WeasyPrint/issues/115>`_:
  Handle ``margin-break``
* `#821 <https://github.com/Kozea/WeasyPrint/issues/821>`_:
  Continuous integration includes tests on Windows

Bug fixes:

* `#765 <https://github.com/Kozea/WeasyPrint/issues/765>`_,
  `#754 <https://github.com/Kozea/WeasyPrint/issues/754>`_,
  `#800 <https://github.com/Kozea/WeasyPrint/issues/800>`_:
  Fix many crashes related to the flex layout
* `#783 <https://github.com/Kozea/WeasyPrint/issues/783>`_:
  Fix a couple of crashes with strange texts
* `#827 <https://github.com/Kozea/WeasyPrint/pull/827>`_:
  Named strings and counters are case-sensitive
* `#823 <https://github.com/Kozea/WeasyPrint/pull/823>`_:
  Shrink min/max-height/width according to box-sizing
* `#728 <https://github.com/Kozea/WeasyPrint/issues/728>`_,
  `#171 <https://github.com/Kozea/WeasyPrint/issues/171>`_:
  Don't crash when fixed boxes are nested
* `#610 <https://github.com/Kozea/WeasyPrint/issues/610>`_,
  `#828 <https://github.com/Kozea/WeasyPrint/issues/828>`_:
  Don't crash when preformatted text lines end with a space
* `#808 <https://github.com/Kozea/WeasyPrint/issues/808>`_,
  `#387 <https://github.com/Kozea/WeasyPrint/issues/387>`_:
  Fix position of some images
* `#813 <https://github.com/Kozea/WeasyPrint/issues/813>`_:
  Don't crash when long preformatted text lines end with ``\n``

Documentation:

* `#815 <https://github.com/Kozea/WeasyPrint/pull/815>`_:
  Add documentation about custom ``url_fetcher``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.