Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of div height of a div with display: flex, with two child divs #885

Closed
rnduldulaojr opened this issue Jun 19, 2019 · 1 comment

Comments

2 participants
@rnduldulaojr
Copy link

commented Jun 19, 2019

Given a parent div with css style:

.content {
    display: flex;
    border-bottom: 1px solid #ccc;
}

and two child divs with CSS:

           .content .left-panel {
                border-right: 1px solid #ccc;
                width: 30%;
                height: 100%;
                padding: 20px 10px 0 0;
            }

            .content .right-panel {
                width: 65%;
                height: 100%;
                padding: 10px 0  0 16px;
            }

the bottom border of the parent seems to be intersecting the children divs. For comparison, I used another library (pdfkit) to generate pdf and the output of that is much close to the web page.

@liZe liZe closed this in 5e0f6d4 Jun 22, 2019

liZe added a commit that referenced this issue Jun 22, 2019

@liZe

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Thank you for this bug report! There was a stupid bug about percentages for flex items, it's fixed now with a non-regression test.

@liZe liZe added the bug label Jun 22, 2019

@liZe liZe added this to the 48 milestone Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.