Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with Pango 1.44 #917

Closed
liZe opened this issue Aug 8, 2019 · 11 comments

Comments

@liZe
Copy link
Member

commented Aug 8, 2019

Pango 1.44 has been released with a lot of changes that break 13 tests (same results on Linux and macOS, that's good news).

@liZe liZe added the bug label Aug 8, 2019

@liZe liZe added this to the 49 milestone Aug 8, 2019

@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Cairo 1.17.2 breaks 2 other tests.

@liZe liZe changed the title Fix tests with Pango 1.44 Fix tests with Pango 1.44 and Cairo 1.17.2 Aug 8, 2019

@liZe liZe changed the title Fix tests with Pango 1.44 and Cairo 1.17.2 Fix tests with Pango 1.44 Aug 8, 2019

@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Cairo 1.17.2 seems to be broken in many ways, let's wait for a more stable snapshot.

liZe added a commit that referenced this issue Aug 8, 2019
Fix tests for Pango 1.44
Fix #917.

One test fails with current 1.44.3 version, because of bug 397 [1] fixed
in 1.44.4 (not released yet).

[1] https://gitlab.gnome.org/GNOME/pango/issues/397
@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

The fix in d6da699 is not really good, it's just a workaround. As it breaks one test with the previous versions of Pango, and as this test is not a corner case, I have to find a better fix.

@Tontyna

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

Why bother with a fix for a broken Pango patch version? Will Pango 1.44.3 be widespread and last for long?

@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Why bother with a fix for a broken Pango patch version? Will Pango 1.44.3 be widespread and last for long?

The fixes are for 1.44.x, not for 1.44.3 only (do you really think I'm such a masochist?). There's no workaround in d6da699 for 1.44.3's bug, we'll wait for 1.44.4 to have tests passing.

But the way line heights are calculated in Pango 1.44.x really breaks WeasyPrint rendering, that's what we have to fix.

@Tontyna

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

do you really think I'm such a masochist?

Of course you are -- it's Saturday! No sane person ever looks after stupid software on weekends

@liZe liZe closed this in aab0fa5 Aug 14, 2019

@Tontyna

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

aab0fa5 is definitely much healthier than d6da699

@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

aab0fa5 is definitely much healthier than d6da699

It is.

@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

The last failing test is fixed in Pango 1.44.4, that has been released (and works for me) but not packaged yet in Homebrew.

@Tontyna

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

MSYS2 is still with Pango 1.43.0 .
There's even a (recent) comment in their PKGBUILD file:

# Don't update to 1.44.0! https://gitlab.gnome.org/GNOME/pango/issues/385

@liZe

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

🎉 https://travis-ci.org/Kozea/WeasyPrint/builds/572272435 🎉

MSYS2 is still with Pango 1.43.0 .
There's even a (recent) comment in their PKGBUILD file:

# Don't update to 1.44.0! https://gitlab.gnome.org/GNOME/pango/issues/385

This issue is fixed now, with a couple of "bad" changes they tried to include and that have been reverted now. These two blog entries (1, 2) are really interesting to understand their choices. We can expect other big changes in the future months, but I'm pretty confident, they know what they're doing.

Cairo 1.17.2 seems to be broken in many ways, let's wait for a more stable snapshot.

This is just a dev snapshot, and they've tried hard to separate stable from unstable releases since 1.16.0, so we can wait a little bit more. My computer was barely usable with it… And I'm not the only one hoping for more regular releases, even Behdad Esfahbod is fed up with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.