Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable variable name typo #983

Closed
benoitkugler opened this issue Oct 29, 2019 · 1 comment
Closed

Probable variable name typo #983

benoitkugler opened this issue Oct 29, 2019 · 1 comment
Milestone

Comments

@benoitkugler
Copy link

@benoitkugler benoitkugler commented Oct 29, 2019

Hi,

In layout/tables.py, line 185, cell.position_y seems a bit suspicious.
Isn't it a typo, which should be replaced by row.position_y ?

Otherwise, it could be the last cell of row.children ?

Thanks for this amazing library !

@liZe

This comment has been minimized.

Copy link
Member

@liZe liZe commented Nov 7, 2019

Hi!

In layout/tables.py, line 185, cell.position_y seems a bit suspicious.
Isn't it a typo, which should be replaced by row.position_y ?

You're right. cell.position_y works too, as it's the last cell's position (which is the same as the row position), but it's much better to use row.position_y here.

@liZe liZe added this to the 51 milestone Nov 7, 2019
@liZe liZe closed this in cebc1ba Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.