Warn broken cairo version #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liZe
requested changes
Feb 6, 2017
|
I see your point, but the Pango>1.38 warning appears at import time of fonts.py as well. Putting it in Document._render would have it appear possibly multiple times. |
True (and I did that 😨).
I think that it's not a bad thing. So let's merge, I'll try to find a better solution before releasing the next version. |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 3, 2017
Version 0.36 ------------ Released on 2017-02-25. New features: * `#407 <https://github.com/Kozea/WeasyPrint/pull/407>`_: Handle ::first-letter. * `#423 <https://github.com/Kozea/WeasyPrint/pull/423>`_: Warn user about broken cairo versions. Bug fixes: * `#411 <https://github.com/Kozea/WeasyPrint/pull/411>`_: Typos fixed in command-line help. Version 0.35 ------------ Released on 2017-02-25. Bug fixes: * `#410 <https://github.com/Kozea/WeasyPrint/pull/410>`_: Fix AssertionError in split_text_box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the broken cairo version is all around (e.g. Debian Jessie), IMHO a warning might help other users.