Warn broken cairo version #423

Merged
merged 1 commit into from Feb 7, 2017

Conversation

Projects
None yet
2 participants
@andreas-p

Since the broken cairo version is all around (e.g. Debian Jessie), IMHO a warning might help other users.

@liZe liZe self-requested a review Feb 6, 2017

@liZe

Good idea, thanks for the PR.

I'd prefer to avoid warnings at the import of the module, because they sometimes appear at the wrong time (for example when you launch weasyprint --help). It may be better in Document._render, what do you think?

@andreas-p

This comment has been minimized.

Show comment
Hide comment
@andreas-p

andreas-p Feb 7, 2017

I see your point, but the Pango>1.38 warning appears at import time of fonts.py as well. Putting it in Document._render would have it appear possibly multiple times.

I see your point, but the Pango>1.38 warning appears at import time of fonts.py as well. Putting it in Document._render would have it appear possibly multiple times.

@liZe

This comment has been minimized.

Show comment
Hide comment
@liZe

liZe Feb 7, 2017

Member

I see your point, but the Pango>1.38 warning appears at import time of fonts.py as well.

True (and I did that 😨).

Putting it in Document._render would have it appear possibly multiple times.

I think that it's not a bad thing.

So let's merge, I'll try to find a better solution before releasing the next version.

Member

liZe commented Feb 7, 2017

I see your point, but the Pango>1.38 warning appears at import time of fonts.py as well.

True (and I did that 😨).

Putting it in Document._render would have it appear possibly multiple times.

I think that it's not a bad thing.

So let's merge, I'll try to find a better solution before releasing the next version.

@liZe liZe merged commit 11bf0c7 into Kozea:master Feb 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@liZe liZe added this to the 0.34 milestone Feb 7, 2017

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Mar 3, 2017

kleink
Update py-weasyprint to 0.36.
Version 0.36
------------

Released on 2017-02-25.

New features:

* `#407 <Kozea/WeasyPrint#407>`_:
  Handle ::first-letter.
* `#423 <Kozea/WeasyPrint#423>`_:
  Warn user about broken cairo versions.

Bug fixes:

* `#411 <Kozea/WeasyPrint#411>`_:
  Typos fixed in command-line help.


Version 0.35
------------

Released on 2017-02-25.

Bug fixes:

* `#410 <Kozea/WeasyPrint#410>`_:
  Fix AssertionError in split_text_box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment