Improve readibility of _select_source function #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacu2
force-pushed
the
improve-readibility-of-_select_source
branch
2 times, most recently
from
65a02f7
to
ee63972
Compare
Pacu2
force-pushed
the
improve-readibility-of-_select_source
branch
from
ee63972
to
6440e25
Compare
|
Thanks a lot! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 9, 2017
Version 0.41 ------------ Released on 2017-10-05. WeasyPrint now depends on pdfrw >= 0.4. New features: * `#471 <https://github.com/Kozea/WeasyPrint/issues/471>`_: Support page marks and bleed. Bug fixes: * `#513 <https://github.com/Kozea/WeasyPrint/issues/513>`_: Don't crash on unsupported image-resolution values. * `#506 <https://github.com/Kozea/WeasyPrint/issues/506>`_: Fix @font-face use with write_* methods. * `#500 <https://github.com/Kozea/WeasyPrint/pull/500>`_: Improve readability of _select_source function. * `#498 <https://github.com/Kozea/WeasyPrint/issues/498>`_: Use CSS prefixes as recommanded by the CSSWG. * `#441 <https://github.com/Kozea/WeasyPrint/issues/441>`_: Fix rendering problems and crashes when using @font-face. * `bb3a4db <https://github.com/Kozea/WeasyPrint/commit/bb3a4db>`_: Try to break pages after a block before trying to break inside it. * `1d1654c <https://github.com/Kozea/WeasyPrint/commit/1d1654c>`_: Fix and test corner cases about named pages. Documentation: * `#508 <https://github.com/Kozea/WeasyPrint/pull/508>`_: Add missing libpangocairo dependency for Debian and Ubuntu. * `a7b17fb <https://github.com/Kozea/WeasyPrint/commit/a7b17fb>`_: Add documentation on logged rendering steps.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 22, 2017
Version 0.41 ------------ Released on 2017-10-05. WeasyPrint now depends on pdfrw >= 0.4. New features: * `#471 <https://github.com/Kozea/WeasyPrint/issues/471>`_: Support page marks and bleed. Bug fixes: * `#513 <https://github.com/Kozea/WeasyPrint/issues/513>`_: Don't crash on unsupported image-resolution values. * `#506 <https://github.com/Kozea/WeasyPrint/issues/506>`_: Fix @font-face use with write_* methods. * `#500 <https://github.com/Kozea/WeasyPrint/pull/500>`_: Improve readability of _select_source function. * `#498 <https://github.com/Kozea/WeasyPrint/issues/498>`_: Use CSS prefixes as recommanded by the CSSWG. * `#441 <https://github.com/Kozea/WeasyPrint/issues/441>`_: Fix rendering problems and crashes when using @font-face. * `bb3a4db <https://github.com/Kozea/WeasyPrint/commit/bb3a4db>`_: Try to break pages after a block before trying to break inside it. * `1d1654c <https://github.com/Kozea/WeasyPrint/commit/1d1654c>`_: Fix and test corner cases about named pages. Documentation: * `#508 <https://github.com/Kozea/WeasyPrint/pull/508>`_: Add missing libpangocairo dependency for Debian and Ubuntu. * `a7b17fb <https://github.com/Kozea/WeasyPrint/commit/a7b17fb>`_: Add documentation on logged rendering steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
During development, I've seen this function, thought it would improve readability a little